Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and implementation for parsing steps. #78

Merged
merged 1 commit into from
Aug 13, 2015

Conversation

jimCresswell
Copy link
Member

  • Test for parsing steps.
  • Implementation for parsing steps.
  • Move complexity from scenario steps defs to compareScenarioValues function (bit too much complexity).
  • Move scenario and background factory into its own module.

* Test for parsing steps.
* Implementation for parsing steps.
* Move complexity from scenario steps defs to compareScenarioValues function (bit too much complexity).
* Move scenario and background factory into its own module.
@sponte sponte requested a deployment to oss-specs-specs-eu-pr-78 August 13, 2015 14:44 Pending
jimCresswell added a commit that referenced this pull request Aug 13, 2015
Add test and implementation for parsing steps.
@jimCresswell jimCresswell merged commit a6a12fa into master Aug 13, 2015
@jimCresswell jimCresswell deleted the feature/parsingSteps branch August 13, 2015 14:44
@sponte
Copy link
Contributor

sponte commented Aug 17, 2015

@jimCresswell, does cucumber-js provide you with Background keyword? If so, that's fine, otherwise we'd would not be able to differentiate between scenario, scenario outline and backgrounds.

@jimCresswell
Copy link
Member Author

Yep, Scenario and Background are keywords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants