Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit button on file pages #213

Merged
merged 6 commits into from
Dec 14, 2015
Merged

Edit button on file pages #213

merged 6 commits into from
Dec 14, 2015

Conversation

jimCresswell
Copy link
Member

Please merge after #212 .

@jimCresswell jimCresswell deployed to oss-specs-specs-eu-pr-213 December 9, 2015 09:35 Active
@jimCresswell
Copy link
Member Author

@sponte this is ready to go.

@sponte
Copy link
Contributor

sponte commented Dec 10, 2015

Should I be expecting to see edit button for markdown and other file types? If so this is not happening in our test app.

@jimCresswell
Copy link
Member Author

In the file view, not on the project view...
On 10 Dec 2015 09:15, "Stanislaw Wozniak" [email protected] wrote:

Should I be expecting to see edit button for markdown and other file
types? If so this is not happening in our test app.


Reply to this email directly or view it on GitHub
#213 (comment).

@jimCresswell jimCresswell deployed to oss-specs-specs-eu-pr-213 December 10, 2015 11:39 Active
@jimCresswell
Copy link
Member Author

No feedback yet, let's merge and iterate.

@sponte
Copy link
Contributor

sponte commented Dec 14, 2015

You sure? Did we not get customer feedback in the end?

@jimCresswell
Copy link
Member Author

I don't think so, not on this.

@jimCresswell
Copy link
Member Author

I was going to add the button to all file types on the project page, let me do that first.

@jimCresswell jimCresswell deployed to oss-specs-specs-eu-pr-213 December 14, 2015 15:55 Active
@jimCresswell
Copy link
Member Author

@sponte okay, edit buttons everywhere.

sponte added a commit that referenced this pull request Dec 14, 2015
@sponte sponte merged commit ecfd5e2 into master Dec 14, 2015
@sponte sponte deleted the feature/editButtonOnFeaturePages branch December 14, 2015 16:13
@sponte
Copy link
Contributor

sponte commented Dec 14, 2015

@jimCresswell edit buttons don't appear on empty and broken features #221

@jimCresswell
Copy link
Member Author

Thanks! I'll have a look at that tomorrow.

On 14 December 2015 at 17:04, Stanislaw Wozniak [email protected]
wrote:

@jimCresswell https://github.com/jimCresswell edit buttons don't appear
on empty and broken features.


Reply to this email directly or view it on GitHub
#213 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants