assignment negative fix #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assign_value = df_assigned.shape[0] - df_unassign.shape[0] | ||
|
|
||
| # prevent negative assignments | ||
| assign_value = 0 if assign_value < 0 else assign_value |
There was a problem hiding this comment.
why can this be negative in the given range?
There was a problem hiding this comment.
Ill be honest its been a while since I implemented this/ I dont think I fully knew at the time either. I think it is if there are assignments before the github apis start point for really large repos (like rust in the example) and then they are unassignments of those it ends up negative
There was a problem hiding this comment.
okay, at minimum this clip the value which is feature-correct lol
JamesKunstle
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a negative assignment plot, closes #708