-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds 8knot oauth usage documentation #705
Conversation
closes #485 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, just one small change. Also, add a reference to this in the readme and get the precommit to pass
docs/user-accounts-in-8knot.md
Outdated
@@ -0,0 +1,38 @@ | |||
# How do user accounts work in 8Knot (OAuth and session handling) | |||
|
|||
8Knot obviously uses some notion of a user account- there are log in / log out buttons, and user groups are persist across logins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"8Knot uses some notion of a user account - there..." or something like that. "Obviously" can come off wrong for new people who this might not be obvious for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
46c232a
to
6f82430
Compare
Signed-off-by: James Kunstle <[email protected]>
6f82430
to
0aa4baa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
have needed to document the usage of oauth in 8Knot for a while. this gives an overview of the files and steps involved
in authenticating user access to groups, and notes gaps in the implementation.
Signed-off-by: James Kunstle [email protected]