Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project velocity viz log 0 error handling #690

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

cdolfi
Copy link
Collaborator

@cdolfi cdolfi commented Apr 5, 2024

Error was happening when there were 0 commits (same would happen to contributors). This fix prevents log from being performed on 0 values. More details in issue

@cdolfi cdolfi added this to the OSS NA Critical Bugs/ TODOs milestone Apr 5, 2024
@cdolfi cdolfi requested a review from JamesKunstle April 5, 2024 17:52
@cdolfi cdolfi linked an issue Apr 5, 2024 that may be closed by this pull request
Copy link
Contributor

@JamesKunstle JamesKunstle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v good change, will merge after preceding PR is done

@JamesKunstle JamesKunstle merged commit e084d91 into oss-aspen:dev Apr 10, 2024
5 checks passed
@cdolfi cdolfi deleted the project_velocity_error branch October 11, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: SCaLE -> OSS NA '24
Development

Successfully merging this pull request may close these issues.

Bug: Project Velocity Viz error when commits are 0
2 participants