grpc: fix ListPath batch_size parameter #2859
Closed
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the append being gated by the length check, for each batch sent, we
were dropped the current path. Change to always append first, then check
the length.
The effect on small batch sizes was dramatic, and best shown with a size
of 1: exactly half of the routes were missing.
GoBGP with 500 routes:
$ ./gobgp global rib -a evpn | wc -l
501
$ ./gobgp global rib -a evpn -b 1 | wc -l
251
$ ./gobgp global rib -a evpn -b 2 | wc -l
335
$ ./gobgp global rib -a evpn -b 500 | wc -l
501
Note: the above example uses 500 routes, but the issue is present even
with two routes.
This commit also adds a --batch-size to gobgp rib commands, to be able
to use the tweak from the cli. It is very useful with a large number of
routes to avoid GoBGP gobbling up gigabytes of memory.
|
Pushed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the append being gated by the length check, for each batch sent, we were dropped the current path. Change to always append first, then check the length.
The effect on small batch sizes was dramatic, and best shown with a size of 1: exactly half of the routes were missing.
GoBGP with 500 routes:
Note: the above example uses 500 routes, but the issue is present even with two routes.
This commit also adds a --batch-size to gobgp rib commands, to be able to use the tweak from the cli. It is very useful with a large number of routes to avoid GoBGP gobbling up gigabytes of memory.