Refactor Prefix-SID and support SRv6 L2 Service TLV #2586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
higebu
changed the title
higebu
force-pushed
the
refactor-prefix-sid
branch
from
94523f3 to
26d3104
Compare
- Add TLVType contant values. - Add NewPathAttributePrefixSID(). - Add SRv6ServiceTLV to support SRv6 L2 Service TLV. - Move reserved field handling to each type of TLV, because header and reserved field size are different for each type. For more details, see https://www.rfc-editor.org/rfc/rfc8669.html and https://www.rfc-editor.org/rfc/rfc9252.html.
higebu
force-pushed
the
refactor-prefix-sid
branch
from
26d3104 to
0869c83
Compare
fujita
reviewed
Oct 15, 2022
| uint32 local_block_length = 1; | ||
| uint32 local_node_length = 2; | ||
| uint32 locator_block_length = 1; | ||
| uint32 locator_node_length = 2; | ||
| uint32 function_length = 3; |
There was a problem hiding this comment.
Thank you for your review. I'll add locator_* as new field and mark old fields as deprecated.
There was a problem hiding this comment.
This feature is still based on RFC drafts. Breaking is fine by me.
There was a problem hiding this comment.
If gobgp prefers RFC-compliant to API backward compatibility, I think we can rename these fields. Because this PR is based on RFC9252.
|
I'll push this pull request as is if it's ok with you. |
|
@fujita It's ok for me. Please merge this PR. Thank you. |
|
pushed, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.