Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mup: handle Type 1 ST Route Prefix as Prefix instead of single address #2579

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

higebu
Copy link
Contributor

@higebu higebu commented Sep 28, 2022

@@ -391,7 +391,7 @@ message MUPType1SessionTransformedRoute {
// - RouteDistinguisherIPAddress
// - RouteDistinguisherFourOctetASN
google.protobuf.Any rd = 1;
uint32 prefix_length = 2;
uint32 prefix_length = 2 [deprecated = true];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No code uses this field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 3 options to remove existing field.

  1. Remove the field.
  2. Add deprecated field option.
  3. Reserve the field number.

Which one is better for the gobgp API?

@fujita fujita merged commit 975db96 into osrg:master Sep 29, 2022
@fujita
Copy link
Member

fujita commented Sep 29, 2022

deprecated looks fine. Pushed, thanks a lot!

@higebu
Copy link
Contributor Author

higebu commented Sep 29, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants