Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sudo with user extension for some usernames #55

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

meyerj
Copy link
Contributor

@meyerj meyerj commented Aug 30, 2019

Not all valid usernames are valid names for files in /etc/sudoers.d/.
We had the problem with a user that has a dot in his username.
The file /etc/sudoers.d/firstname.lastname was ignored by sudo.

Not all valid usernames are valid names for files in /etc/sudoers.d/.
We had the problem with a user that has a dot in his username.
The file /etc/sudoers.d/firstname.lastname was ignored by sudo.
@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files           5        5           
  Lines         390      390           
=======================================
  Hits          325      325           
  Misses         65       65

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9420de4...6d2b63f. Read the comment docs.

@tfoote tfoote merged commit 0bc20b8 into osrf:master Sep 11, 2019
130s pushed a commit to plusone-robotics/rocker that referenced this pull request Apr 17, 2021
Not all valid usernames are valid names for files in /etc/sudoers.d/.
We had the problem with a user that has a dot in his username.
The file /etc/sudoers.d/firstname.lastname was ignored by sudo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants