Fix reporting targets from RGBD camera #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
This was referenced Aug 17, 2022
Closed
caguero
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
fixes #209.
Problem was that rgbd camera does not support the
VisualAtfunction that is used to identify targets. I worked around the issue by creating a regular camera with the rgbd camera's resolution and hfov, which is used in place of the rgbd camera when a target report is received.Steps for testing are similar to #195. Instead of using an
mbzirc_hd_camera, use anmbzirc_rgbd_camera. The rgbd camera has lower resolution so when reporting targets, change coordinates to320,240