Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #14. Remove launch file. #102

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Conversation

arjo129
Copy link
Member

@arjo129 arjo129 commented Dec 1, 2021

This PR removes the launch file as it is not needed anymore.

Signed-off-by: Arjo Chakravarty [email protected]

Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 linked an issue Dec 1, 2021 that may be closed by this pull request
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove these too:

find_package(ignition-launch5 REQUIRED)

lrauv_ignition_plugins/hooks/hook.dsv.in Outdated Show resolved Hide resolved
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina enabled auto-merge (squash) December 1, 2021 19:49
@chapulina chapulina merged commit 7b8428d into main Dec 1, 2021
@chapulina chapulina deleted the arjo/refactor/remove_launch_file branch December 1, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What's the goal of the launch file?
2 participants