-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the VBS to sink causes the vehicle to translate forwards and go into a spin. #47
Comments
Spinning in yaw seems to be from the Added Mass terms and Translation is from the damping terms. |
I've narrowed this down to an issue of transformations. Basically by sprinkling debug statements throughout the course of the Hydrodynamics plugin I get the following:
The hydrodynamics should produce a force which opposes the direction of motion. This is happening in the local frame correctly, however when we transform back to the global frame we get incorrect results. |
HI @arjo129, almost looks like the buoyancy force is stuck in the vehicle frame and not translated into the internal frame — I'd expect the buoyancy force to always work against gravity, regardless of the vehicle's orientation. What do you think? |
I checked and its not that. The buoyancy force from the vbs is always pointing opposite gravity. Its not very clear in the video but when I print it I see that its only acting in the Z axis.The hydro on the other hand is all over the place. |
…ss of the baselink back and move the center of mass of the vehicle forward. This helps resolve some of the spinning in #47. It also is based on the actual positions of the robot. The second change made is an increase in distance between the linkand the center of volume. This helps damp oscillations when running `testPitchMass.xml`. Additionally, this commit updates the pitchmass plots to contain the Error as well as the current Pitch command. Signed-off-by: Arjo Chakravarty <[email protected]>
…ss of the baselink back and move the center of mass of the vehicle forward. This helps resolve some of the spinning in #47. It also is based on the actual positions of the robot. The second change made is an increase in distance between the linkand the center of volume. This helps damp oscillations when running `testPitchMass.xml`. Additionally, this commit updates the pitchmass plots to contain the Error as well as the current Pitch command. Signed-off-by: Arjo Chakravarty <[email protected]>
How to reproduce:
In one terminal:
In another:
Expected behavior
The vehicle pitches a little bit and then sinks mostly vertically.
Current behaviour
The vehicle sinks but keeps getting pushed backwards, this is likely to some weird numerical issue.
The text was updated successfully, but these errors were encountered: