Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add water mass tracking support to DVL #223

Closed
Tracked by #225
hidmic opened this issue Jul 4, 2022 · 5 comments
Closed
Tracked by #225

Add water mass tracking support to DVL #223

hidmic opened this issue Jul 4, 2022 · 5 comments
Assignees
Milestone

Comments

@hidmic
Copy link
Collaborator

hidmic commented Jul 4, 2022

A bottom tracking DVL sensor was introduced by #213, and now we need water mass tracking capabilities.

@hidmic hidmic added this to the 2022 M3 milestone Jul 4, 2022
@hidmic
Copy link
Collaborator Author

hidmic commented Jul 4, 2022

@arjo129 @caguero @braanan @adityapande-1995 our current model for underwater currents is somewhat simplistic: a global constant velocity by default, can be modified globally during simulation. Science data includes water speed measurements we could reuse, though I'm not sure if these measurements get us full water column data.

How shall we go about this? If we go with science data (ie. the path of least resistance):

  • Should we split data lookup functionality out of the science data plugin for reuse first?
  • Should we use chlorophyll concentration to model beam reflectivity? Another step function would be fine, at least for starters.

@arjo129
Copy link
Member

arjo129 commented Jul 5, 2022 via email

@hidmic
Copy link
Collaborator Author

hidmic commented Jul 5, 2022

My proposal is that we would put
parsing logic in gz-common and reuse VolumetricGridLookupField. I also
think we should implement a TimeVaryingVolumetricGridLookupField using
VolumetricGridLookUpField.

Sounds like a plan.

We should find a way of centralizing all the
data as I suspect the in-memory format might get quite big and hosting
multiple copies of it would be highly inefficient.

Agreed. Perhaps as a component?

The hydrodynamics plugin supports a per-model
current. This means that we can modify the current on the fly for each
vehicle based on the vehicle's position.

Ah, good point. I was thinking of a single vehicle. Either way, for the purposes of a DVL, my point is that we don't model the physics of the entire water column and thus there's nothing the sensor can retrieve.

@arjo129
Copy link
Member

arjo129 commented Jul 6, 2022

Agreed. Perhaps as a component?

In my mind a component works as long as we dont serialize the component along with the data. Serializing the data would be ☠️ . We will need to get all of these pieces in as draft PRs before jul 27th. While Im officially on reservist the next 3 weeks I can probably manage it.

@caguero caguero mentioned this issue Jul 7, 2022
22 tasks
@hidmic hidmic self-assigned this Aug 18, 2022
@hidmic
Copy link
Collaborator Author

hidmic commented Oct 26, 2022

Done as of #241.

@hidmic hidmic closed this as completed Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants