Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: document bottle building procedure #1007

Merged
merged 13 commits into from
Sep 30, 2020
Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented May 9, 2020

This works on adding some documentation for the homebrew bottle building process, but it is still a work in progress.

@scpeters scpeters requested a review from chapulina May 9, 2020 05:11
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Just one minor comment

README.md Outdated Show resolved Hide resolved
@iche033 iche033 self-requested a review May 12, 2020 19:18
README.md Outdated Show resolved Hide resolved
README.md Outdated

After starting a bottle building job

The GitHub build status that appears in each PR is mainly checking that bottles can be fetched.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is implying that something isn't being checked, but I don't know what that would be.

README.md Outdated Show resolved Hide resolved
@scpeters scpeters marked this pull request as ready for review May 31, 2020 04:18
@scpeters
Copy link
Member Author

scpeters commented Jun 8, 2020

I just resolved conflicts after merging in the bottle status badges in #1044

@scpeters scpeters changed the title README: add more docs about bottles README: document bottle building procedure Sep 26, 2020
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @scpeters !

@scpeters scpeters merged commit 7d10970 into osrf:master Sep 30, 2020
@scpeters scpeters deleted the bottle_docs branch September 30, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants