Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for pytest #458

Closed
wants to merge 1 commit into from
Closed

Remove workaround for pytest #458

wants to merge 1 commit into from

Conversation

ruffsl
Copy link
Member

@ruffsl ruffsl commented Sep 24, 2020

@mikaelarguedas
Copy link
Contributor

These lines act as integration tests as well. They ensure that pytest is installed and found properly. I think there is value in keeping them to catch future breakages early

@ruffsl
Copy link
Member Author

ruffsl commented Sep 25, 2020

These lines act as integration tests as well. They ensure that pytest is installed and found properly.

Not sure how the current directive halts the image build if the incorrect pytest version is found, vs. if it's not found at all.

I think there is value in keeping them to catch future breakages early

Ok. Lets let it be then.

@ruffsl ruffsl closed this Sep 25, 2020
@mikaelarguedas
Copy link
Contributor

We had an issue that some versions were incompatible preventing python from finding pytest at all.
This ensures that pytest can be found / invoked meaning there is a "working" version. We do not enforce version number as long as pytest can be used

@mikaelarguedas mikaelarguedas deleted the revert-pytest-patch branch September 25, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants