Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding all default parameters sets rates to 0 #160

Closed
talumbau opened this issue Feb 19, 2016 · 0 comments
Closed

Rounding all default parameters sets rates to 0 #160

talumbau opened this issue Feb 19, 2016 · 0 comments
Assignees
Labels

Comments

@talumbau
Copy link
Member

With the merge of #159 a bug was introduced. Since we enforce rounding every value to the nearest integer, all default rates are set to 0. This is bad. The proper rule should be 'every default parameter value that is greater than 1.0 should be rounded to the nearest whole number. any value less than 1.0 should be left alone'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant