-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support kwargs in method calls #440
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
1964d91
remove support for instance literals in constructors
leina05 7d19460
update all instance creation syntax to use () not {}
leina05 dd33611
add kwargs to external calls
leina05 1925664
support kwargs in ruby methods
leina05 e00f95d
python test for kwarg methods
leina05 244c81b
rubocop
leina05 2f069b2
Slightly simplify Ruby kwargs handling
plotnick 03eda17
update call macro for kwargs; use Call for constructors in tests inst…
leina05 222b570
Thread kwargs through integration tests
plotnick c1c56a3
add kwarg tests to rust integration_test
leina05 55f9106
Fix calls with kwargs on Ruby < 2.7
plotnick 92daa7c
Comment Ruby version stuff
plotnick 527ffa9
add no kwarg check to Java for calls
leina05 3783ec0
ruby test for kwargs with method calls
leina05 31d1f9b
broken JS tests, WIP
leina05 63f54b9
Kill SimpleCall lalrpop production
plotnick 900dedc
Fix JS kwargs tests
plotnick f95a411
Tweak Python kwargs handling
plotnick 688eb76
add kwargs to POLAR_LOG
plotnick 03269d5
format
plotnick c141f31
Merge branch 'main' into leina/ship_mixed_args
plotnick 7412489
whitespace
plotnick 60a0d5c
whitespace
plotnick a790afb
Async keyword only needed if await used in function body
gj 00d183a
Assert against error type instead of string matching
gj 5d1b47d
Changelog
gj 9ea90c9
Merge branch 'main' into leina/ship_mixed_args
samscott89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.