Partial unlocking implementation #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
reviewed
Feb 17, 2022
|
It might help, the old PR #543 has partial unlocking implemented that you can reference to! |
Codecov Report
@@ Coverage Diff @@
## main #893 +/- ##
==========================================
+ Coverage 20.38% 21.69% +1.30%
==========================================
Files 192 192
Lines 24783 25626 +843
==========================================
+ Hits 5053 5559 +506
- Misses 18798 19065 +267
- Partials 932 1002 +70
Continue to review full report at Codecov.
|
ValarDragon
reviewed
Feb 18, 2022
ValarDragon
reviewed
Feb 18, 2022
ValarDragon
reviewed
Feb 18, 2022
| @@ -59,9 +60,17 @@ func (k Keeper) GetAllSyntheticLockupsByLockup(ctx sdk.Context, lockID uint64) [ | |||
| return synthLocks | |||
| } | |||
|
|
|||
| func (k Keeper) HasAnySyntheticLockups(ctx sdk.Context, lockID uint64) bool { | |||
There was a problem hiding this comment.
Nice, this is a good fn to have!
ValarDragon
reviewed
Feb 18, 2022
ValarDragon
reviewed
Feb 18, 2022
Comment on lines
+244
to
+246
| locked = suite.app.LockupKeeper.GetAccountLockedCoins(suite.ctx, addr1) | ||
| suite.Require().Equal(len(locked), 1) | ||
| suite.Require().Equal(locked[0].Amount.Int64(), int64(10)) |
There was a problem hiding this comment.
GetAccountLockedCoins returns all coins that is qualified for reward, so it includes unlocking coins. Will add logic for checking 9 case!
ValarDragon
reviewed
Feb 18, 2022
Co-authored-by: Dev Ojha <[email protected]>
ValarDragon
approved these changes
Feb 19, 2022
UnityChaos
pushed a commit
that referenced
this pull request
Feb 20, 2022
* add partial unlock logic * add partial unlock test * fix lint * Apply suggestions from code review Co-authored-by: Dev Ojha <[email protected]> * add test for case after unlocking period Co-authored-by: Dev Ojha <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Description
For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer