fix: increase unauthenticated gas to fix fee token issue

[PaddyMc]

What is the purpose of the change

The current estimate for unauthenticated gas is far to low, the node ran into issues when we tried to execute transaction using fee tokens other than uosmo as the was another read from the store.

We increase the unauthenticated gas from 120_000 => 200_000 to enable multiple fee tokens

How to test

• 1 run in-place-testnet

• osmosisd q smartaccount params

• 2 run tests in the v26 upgrade folder

• cd ./app/upgrades/v26

• go test ./...

[coderabbitai]

Walkthrough

The recent updates enhance the handling of unauthenticated transactions by introducing a new gas limit constant and refining the upgrade process. Key changes include the addition of MaximumUnauthenticatedGas, modifications to the upgrade handler to apply this parameter, and new test cases to validate the implementation. These enhancements aim to improve the efficiency and reliability of transaction processing within the system.

Changes

File Path	Change Summary
CHANGELOG.md	Added entry documenting the fix for gas limits in unauthenticated transactions linked to PR #8573.
app/upgrades/v26/constants.go	Introduced MaximumUnauthenticatedGas constant for managing gas limits; improved constant organization.
app/upgrades/v26/upgrades.go	Modified CreateUpgradeHandler to update MaximumUnauthenticatedGas during upgrades.
app/upgrades/v26/upgrades_test.go	Added tests for setting and verifying MaximumUnauthenticatedGas parameter.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5e64f0e and 707c163.

Files selected for processing (1)

• app/upgrades/v26/constants.go (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/upgrades/v26/constants.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ValarDragon]

Can we make this higher, e.g. 300k to 500k

[PaddyMc]

I defo want to keep this as low as possible, I bumped to 250k, I think if we reach this, we need to optimise the authentication flow not increase gas

[ValarDragon]

LGTM but lets please make the number higher