Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce commit timeout to 500ms to enable faster blocks #8546

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

PaddyMc
Copy link
Contributor

@PaddyMc PaddyMc commented Jul 24, 2024

What is the purpose of the change

Reducing block time to 1.5s by reducing timeout_commit to 200ms

Copy link
Contributor

coderabbitai bot commented Jul 24, 2024

Walkthrough

The change involves modifying the timeout_commit configuration value in the consensus mechanism from "600ms" to "500ms" and adjusting the timeout_propose value from "2s" to "1.8s" in the cmd/osmosisd/cmd/root.go file. These adjustments reduce the allowable time for commit and propose operations, enhancing system responsiveness but potentially increasing the risk of timeouts during high load situations.

Changes

File Path Change Summary
cmd/osmosisd/cmd/root.go Changed timeout_commit from "600ms" to "500ms" and timeout_propose from "2s" to "1.8s" in the consensus section.
CHANGELOG.md Added entry for version v25.2.0 documenting the timeout changes from pull request #8546.

Sequence Diagram(s)

No sequence diagrams are necessary for these changes as they are straightforward and do not introduce new features or complex interactions.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@PaddyMc PaddyMc marked this pull request as draft July 24, 2024 16:31
@PaddyMc PaddyMc force-pushed the feat/overwrite-commit-timeout-0.5s branch from fd9eee7 to 6fe74c9 Compare July 25, 2024 09:48
@PaddyMc PaddyMc marked this pull request as ready for review July 25, 2024 09:48
@PaddyMc PaddyMc added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v25.x backport patches to v25.x branch labels Jul 25, 2024
@PaddyMc PaddyMc changed the title feat: reduce commit timeout to 200ms to enable faster blocks feat: reduce commit timeout to 500ms to enable faster blocks Jul 25, 2024
@PaddyMc PaddyMc merged commit 1c90fab into main Jul 25, 2024
1 check passed
@PaddyMc PaddyMc deleted the feat/overwrite-commit-timeout-0.5s branch July 25, 2024 11:27
mergify bot pushed a commit that referenced this pull request Jul 25, 2024
* feat: reduce commit timeout to 200ms to enable faster blocks

* feat: reduce commit timeout to 500ms and propose timeout to 1.8s

(cherry picked from commit 1c90fab)

# Conflicts:
#	CHANGELOG.md
PaddyMc added a commit that referenced this pull request Jul 25, 2024
…#8546) (#8550)

* feat: reduce commit timeout to 500ms to enable faster blocks (#8546)

* feat: reduce commit timeout to 200ms to enable faster blocks

* feat: reduce commit timeout to 500ms and propose timeout to 1.8s

(cherry picked from commit 1c90fab)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: PaddyMc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v25.x backport patches to v25.x branch V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants