Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: datadog wiring (main) #8543

Merged
merged 5 commits into from
Jul 28, 2024
Merged

feat: datadog wiring (main) #8543

merged 5 commits into from
Jul 28, 2024

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jul 24, 2024

Closes: #XXX

What is the purpose of the change

  • Enables DataDog tracing.
  • Tested and deployed on SQS in staging and production

image

@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v25.x backport patches to v25.x branch labels Jul 24, 2024
@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Jul 24, 2024
@p0mvn p0mvn marked this pull request as ready for review July 24, 2024 05:11
Copy link
Contributor

coderabbitai bot commented Jul 24, 2024

Walkthrough

The recent changes significantly enhance the application's observability by integrating OpenTelemetry (OTEL) for improved monitoring and tracing capabilities. Key updates include the introduction of an OTEL configuration structure, the implementation of an OTEL tracer initialization function, and enhancements to the gRPC client instrumentation. These updates enable more effective performance tracking and debugging, marking a notable advancement in the application's operational monitoring features.

Changes

File Path Change Summary
app/.../app.go Integrated OpenTelemetry support; added OTEL initialization function and configuration retrieval.
app/.../config.go Introduced OTELConfig type for managing OTEL settings and a function to create this configuration.
cmd/.../cmd/root.go Added OTEL configuration section to application initialization, allowing users to set OTEL options.
ingest/.../grpc_client.go Enhanced gRPC client with OpenTelemetry stats handler for improved monitoring of gRPC operations.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Outside diff range, codebase verification and nitpick comments (1)
app/app.go (1)

1280-1281: Ensure comments are clear and accurate.

The comment mentions wiring up with the Sentry exporter, but there is no Sentry-specific code in the function.

- // and wires it up with the Sentry exporter.
+ // and sets up the tracer provider and text map propagator.

app/app.go Show resolved Hide resolved
app/app.go Show resolved Hide resolved
@p0mvn p0mvn closed this Jul 28, 2024
@p0mvn p0mvn reopened this Jul 28, 2024
@p0mvn p0mvn merged commit c45c477 into main Jul 28, 2024
1 check passed
@p0mvn p0mvn deleted the roman/datadog-main branch July 28, 2024 07:22
mergify bot pushed a commit that referenced this pull request Jul 28, 2024
* feat: datadog wiring (main)

* changelog

* updates

(cherry picked from commit c45c477)

# Conflicts:
#	app/config.go
#	go.mod
#	go.sum
p0mvn added a commit that referenced this pull request Jul 28, 2024
p0mvn added a commit that referenced this pull request Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge A:backport/v25.x backport patches to v25.x branch C:app-wiring Changes to the app folder V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants