-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wasmd #8332
Update wasmd #8332
Conversation
WalkthroughThe recent updates to the Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant AppKeepers
participant Module
User->>AppKeepers: Initialize AppKeepers
AppKeepers->>Module: InitNormalKeepers
Module->>Module: Set supportedFeatures to ["iterator", "staking", "stargate", "osmosis", "cosmwasm_1_1", "cosmwasm_1_2", "cosmwasm_1_4", "cosmwasm_2_0"]
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
app/keepers/keepers.go (1)
Line range hint
87-87
: Failed to importgithub.com/osmosis-labs/osmosis/v25/wasmbinding
. Please verify the existence and accessibility of this package.
@@ -46,7 +46,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
* [#8169](https://github.com/osmosis-labs/osmosis/pull/8169) Support non-pool assets in superfluid staking | |||
* [#8274](https://github.com/osmosis-labs/osmosis/pull/8274) SDK v50 and Comet v0.38 upgrade | |||
|
|||
* [#8332](https://github.com/osmosis-labs/osmosis/pull/8332) Update wasmd to v0.51.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
The changelog entry for PR #8332 lacks a brief description of the changes made. The entry only includes "### State Compatible," which does not provide sufficient detail about the update to wasmd
v0.51.0.
- Line 49 in
CHANGELOG.md
needs a more detailed description of the changes made in PR Update wasmd #8332.
Analysis chain
Ensure the changelog entry for PR #8332 includes a brief description of the changes made, especially since it involves a significant update like wasmd
to v0.51.0.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the changelog entry for PR #8332 includes a description of the changes.
# Test: Search for the PR entry and check for a description.
grep -A 3 "#8332" CHANGELOG.md | grep -v "^\*"
Length of output: 70
Important Notice This PR includes modifications to the
Please let us know if you need any help. |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
closing in favour of => #8616 Sorry @nicolaslara I was struggling with the merge, and I thought this would be quicker 🙏 |
No worries! I was gonna work on it tomorrow. Same for the conflicts on the ibc one |
What is the purpose of the change
Update wasmd to support cosmwasm >= 2.0
Testing and Verifying
all tests should pass
Documentation and Release Note
Unreleased
section ofCHANGELOG.md
?Where is the change documented?
x/{module}/README.md
)