Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasmd #8332

Closed
wants to merge 11 commits into from
Closed

Update wasmd #8332

wants to merge 11 commits into from

Conversation

nicolaslara
Copy link
Contributor

@nicolaslara nicolaslara commented May 30, 2024

What is the purpose of the change

Update wasmd to support cosmwasm >= 2.0

Testing and Verifying

all tests should pass

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

Copy link
Contributor

coderabbitai bot commented May 30, 2024

Walkthrough

The recent updates to the osmosis project enhance superfluid staking by supporting non-pool assets, upgrade dependencies to SDK v50 and Comet v0.38, and update wasmd to v0.51.0. Additionally, the InitNormalKeepers function now uses a string slice for supportedFeatures, adding "cosmwasm_2_0" to the list.

Changes

Files Change Summary
CHANGELOG.md Added support for non-pool assets in superfluid staking, upgraded to SDK v50, Comet v0.38, and updated wasmd to v0.51.0.
app/keepers/keepers.go Updated supportedFeatures in InitNormalKeepers from a string to a string slice, adding "cosmwasm_2_0".

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant AppKeepers
    participant Module
    User->>AppKeepers: Initialize AppKeepers
    AppKeepers->>Module: InitNormalKeepers
    Module->>Module: Set supportedFeatures to ["iterator", "staking", "stargate", "osmosis", "cosmwasm_1_1", "cosmwasm_1_2", "cosmwasm_1_4", "cosmwasm_2_0"]
Loading

Poem

In the world of code so bright and new,
Osmosis grows with features true,
Superfluid stakes now broadened wide,
With SDK v50, we stride.
Cosmwasm 2.0, a welcome guest,
In keepers' hearts, it finds its nest.
A rabbit's joy, in code we trust,
For Osmosis, evolve we must! 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the C:app-wiring Changes to the app folder label May 30, 2024
@nicolaslara nicolaslara added the V:state/breaking State machine breaking PR label May 30, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (1)
app/keepers/keepers.go (1)

Line range hint 87-87: Failed to import github.com/osmosis-labs/osmosis/v25/wasmbinding. Please verify the existence and accessibility of this package.

@@ -46,7 +46,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* [#8169](https://github.com/osmosis-labs/osmosis/pull/8169) Support non-pool assets in superfluid staking
* [#8274](https://github.com/osmosis-labs/osmosis/pull/8274) SDK v50 and Comet v0.38 upgrade

* [#8332](https://github.com/osmosis-labs/osmosis/pull/8332) Update wasmd to v0.51.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The changelog entry for PR #8332 lacks a brief description of the changes made. The entry only includes "### State Compatible," which does not provide sufficient detail about the update to wasmd v0.51.0.

  • Line 49 in CHANGELOG.md needs a more detailed description of the changes made in PR Update wasmd #8332.
Analysis chain

Ensure the changelog entry for PR #8332 includes a brief description of the changes made, especially since it involves a significant update like wasmd to v0.51.0.

Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the changelog entry for PR #8332 includes a description of the changes.

# Test: Search for the PR entry and check for a description.
grep -A 3 "#8332" CHANGELOG.md | grep -v "^\*"

Length of output: 70

@nicolaslara nicolaslara changed the title Nicolas/update cosmwasm Update wasmd May 30, 2024
@nicolaslara nicolaslara marked this pull request as draft May 30, 2024 15:35
Copy link
Contributor

github-actions bot commented May 30, 2024

Important Notice

This PR includes modifications to the tests/e2e/initialization module.
Please follow the instructions below:

  1. Backport these changes to the previous Osmosis version's branch.
  2. Run the script inside a Docker container to update genesis and configs for pre-upgrade Osmosis.
  3. Merge the backported changes.
  4. The image will be built and uploaded to Docker Hub here.
  5. Grab the latest image and update it in the PR to the main branch replacing the previousVersionInitTag in the osmosis/tests/e2e/containers/config.go

Please let us know if you need any help.

@PaddyMc PaddyMc closed this Jun 3, 2024
@PaddyMc PaddyMc reopened this Jun 3, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@PaddyMc
Copy link
Contributor

PaddyMc commented Aug 14, 2024

closing in favour of => #8616

Sorry @nicolaslara I was struggling with the merge, and I thought this would be quicker 🙏

@PaddyMc PaddyMc closed this Aug 14, 2024
@nicolaslara
Copy link
Contributor Author

No worries! I was gonna work on it tomorrow. Same for the conflicts on the ibc one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants