Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing swap event for cw pool (backport #7938) #7950

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 3, 2024

Closes: #XXX

What is the purpose of the change

Numia team has a problem tracking swap events for a CW pool. The reason is that the event is missing.

Context: https://osmosis-network.slack.com/archives/C04M8FQ5Y2G/p1712020788660349

While there is a workaround that they can implement, it would be a hack looking for events at another layer of abstraction.

I propose adding this change to the v24 scope. The core of the change is emitting the swap event in x/cosmwasmpool.

I evaluated the option of emitting this at the poolmanager layer. However, given that we have many swap APIs, it would take some careful effort to make sure that nothing is missed. Given the above, it is cleaner and less risky to simply add the event at the x/cosmwasmpool level.

Given that events are now state breaking, it is important to account for the above risks.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

Summary by CodeRabbit

  • New Features
    • Introduced missing swap events for CW pools to enhance transparency and tracking of swap activities.
  • Refactor
    • Revised swap event emission logic to occur at the pool module layer, improving modularity and clarity in event handling across different pool modules.
  • Documentation
    • Added comments to clarify the new approach for emitting swap events, ensuring better understanding and implementation in future developments.

This is an automatic backport of pull request #7938 done by [Mergify](https://mergify.com).

* fix: missing swap event for cw pool

* changelog

(cherry picked from commit c99b1c7)
@mergify mergify bot assigned p0mvn Apr 3, 2024
@github-actions github-actions bot added C:x/gamm Changes, features and bugs related to the gamm module. C:x/concentrated-liquidity C:x/poolmanager labels Apr 3, 2024
@czarcas7ic czarcas7ic merged commit c6c49b7 into v24.x Apr 3, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the mergify/bp/v24.x/pr-7938 branch April 3, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. C:x/poolmanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants