Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate app.go #795

Closed
wants to merge 7 commits into from
Closed

Annotate app.go #795

wants to merge 7 commits into from

Conversation

faddat
Copy link
Member

@faddat faddat commented Jan 27, 2022

Closes: #XXX

Description

While building Craft Economy and trying to become more familiar with the cosmos SDK, and familiarize others, I ended up annotating app.go, and found it really helpful, so I figured that I might as well annotate Osmosis' app.go, too!


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@ethanfrey
Copy link
Contributor

This is nice to explain to people how it works.

app/app.go Outdated Show resolved Hide resolved
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once suggested comment change is in! ( I don't have perms to push to the branch)

Thanks for adding this, should help onboarding!

Co-authored-by: Dev Ojha <[email protected]>
@faddat
Copy link
Member Author

faddat commented Jan 27, 2022

Onboarding is gonna be an ecosystem-wide team effort....

@codecov-commenter
Copy link

Codecov Report

Merging #795 (d29a93b) into sunny/sdk-v0.45 (aaf9565) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           sunny/sdk-v0.45     #795   +/-   ##
================================================
  Coverage            19.96%   19.96%           
================================================
  Files                  189      189           
  Lines                24542    24542           
================================================
  Hits                  4900     4900           
  Misses               18787    18787           
  Partials               855      855           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaf9565...d29a93b. Read the comment docs.

@ValarDragon ValarDragon deleted the branch osmosis-labs:sunny/sdk-v0.45 January 28, 2022 05:33
@ValarDragon
Copy link
Member

Wait what, why did merging sunny's PR close this, I thought github auto-updates PRs to re-target main >:(

@ValarDragon
Copy link
Member

I don't have perms to reopen off your fork

@faddat
Copy link
Member Author

faddat commented Jan 28, 2022

hey no worries-- I'll push to osmosis-labs in the future and resubmit :)

@github-actions github-actions bot mentioned this pull request Mar 15, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants