Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor state compatible speedups to txfees #7535

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

ValarDragon
Copy link
Member

Pretty minor speedups to txfees. This is taking a pretty small amount of time in profiles, but driveby noticed it, hence PR'ing slight improvements. THere are better improvements via reducing the number of math ops in a state breaking change, which we should eventually do.

Also made some slight speedups to relevant ops in upstream SDK, which we should get on next math version bump. (cosmos/cosmos-sdk#19467, cosmos/cosmos-sdk#19466)

@ValarDragon ValarDragon added V:state/compatible/backport State machine compatible PR, should be backported A:no-changelog A:backport/v23.x backport patches to v23.x branch labels Feb 19, 2024
@ValarDragon ValarDragon merged commit d563553 into main Feb 19, 2024
1 check passed
@ValarDragon ValarDragon deleted the dev/minor_speedup_txfee branch February 19, 2024 14:33
mergify bot pushed a commit that referenced this pull request Feb 19, 2024
ValarDragon added a commit that referenced this pull request Feb 19, 2024
(cherry picked from commit d563553)

Co-authored-by: Dev Ojha <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
@github-actions github-actions bot mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v23.x backport patches to v23.x branch A:no-changelog C:x/txfees V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants