Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: in-place testnet creator #7374

Merged
merged 8 commits into from
Feb 6, 2024
Merged

feat: in-place testnet creator #7374

merged 8 commits into from
Feb 6, 2024

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Jan 28, 2024 •
edited
Loading

Closes: #XXX

What is the purpose of the change

In place testnet creator wiring.

Testing and Verifying

Tested by both myself and Roman.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@github-actions github-actions bot added C:x/epochs C:app-wiring Changes to the app folder labels Jan 28, 2024
@czarcas7ic czarcas7ic added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v22.x backport patches to v22.x branch labels Jan 28, 2024
@p0mvn p0mvn mentioned this pull request Jan 31, 2024
Closed
@czarcas7ic czarcas7ic marked this pull request as ready for review February 6, 2024 17:57
p0mvn
p0mvn approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Already used this to set up Block SDK testnet 🚀

@czarcas7ic czarcas7ic merged commit 0b32654 into main Feb 6, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the adam/testnetify branch February 6, 2024 20:07
mergify bot pushed a commit that referenced this pull request Feb 6, 2024
@czarcas7ic @mergify
feat: in-place testnet creator (#7374)
b11b312 
* plug in testnetify

* fix import

* utilize appOpts

* add upgrade trigger

* update sdk fork tag

* add changelog

(cherry picked from commit 0b32654)

# Conflicts:
#	CHANGELOG.md
#	go.sum
@mergify mergify bot mentioned this pull request Feb 6, 2024
Merged
czarcas7ic added a commit that referenced this pull request Feb 6, 2024
@mergify @czarcas7ic
feat: in-place testnet creator (backport #7374) (#7424)
350901e 
* feat: in-place testnet creator (#7374)

* plug in testnetify

* fix import

* utilize appOpts

* add upgrade trigger

* update sdk fork tag

* add changelog

(cherry picked from commit 0b32654)

# Conflicts:
#	CHANGELOG.md
#	go.sum

* fix conflicts

* go mod tidy

---------

Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@nicolaslara nicolaslara Awaiting requested review from nicolaslara nicolaslara is a code owner

Assignees
No one assigned
Labels
A:backport/v22.x backport patches to v22.x branch C:app-wiring Changes to the app folder C:x/epochs V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czarcas7ic @p0mvn