Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update gov type for Set-Scaling-Factor #7360

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

puneet2019
Copy link
Member

Closes: #XXX

What is the purpose of the change

Add a description of the overall background and high level changes that this PR introduces

(E.g.: This pull request improves documentation of area A by adding ....

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added unit test that validates ...
  • Added integration tests for end-to-end deployment with ...
  • Extended integration test for ...
  • Manually verified the change by ...

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Jan 24, 2024
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks! @puneet2019 Can you add a changelog entry for this? 🙇

@mattverse mattverse added the V:state/breaking State machine breaking PR label Jan 24, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@czarcas7ic czarcas7ic closed this Jan 29, 2024
@czarcas7ic czarcas7ic reopened this Jan 29, 2024
@czarcas7ic czarcas7ic merged commit b227fc5 into main Jan 29, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the puneet2019-patch-1 branch January 29, 2024 23:10
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
@github-actions github-actions bot mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants