Reduce taker fee param loading #7259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
requested review from
czarcas7ic,
p0mvn,
mattverse and
AlpinYukseloglu
as code owners
PaddyMc
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently chargeTakerFee is expensively loading all the pool manager params. This lowers what it loads to be the minimum amount (which may still be too large in general) but should lower costs a bit.
This reduces gas costs by at least 10k gas per swap, potentially more.
What is the purpose of the change
Speedup
chargeTakerFeewhich is too gas expensive and CPU intense. We need to further revisit this later, though these terms may be less bad after the fee tracker changes. (This, plus the fee tracker changes has the potential to 5x reduce this overhead. Not expecting it to be that good though, and still think this needs rethinking)Testing and Verifying
This should be covered by existing tests