Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove cl test modules #7254

Merged
merged 2 commits into from
Jan 8, 2024
Merged

chore: remove cl test modules #7254

merged 2 commits into from
Jan 8, 2024

Conversation

czarcas7ic
Copy link
Member

Closes: #XXX

What is the purpose of the change

Whenever having to do go mod updates, there is overhead in also syncing the cl test modules as well. AFAIK these are not being used, and if they are I think its better off outside of the primary repo.

@czarcas7ic czarcas7ic added V:state/compatible/backport State machine compatible PR, should be backported A:no-changelog A:backport/v21.x backport patches to v21.x branch labels Jan 6, 2024
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Jan 6, 2024
@czarcas7ic czarcas7ic marked this pull request as ready for review January 7, 2024 01:49
@p0mvn p0mvn merged commit 2946424 into main Jan 8, 2024
1 check passed
@p0mvn p0mvn deleted the adam/remove-cl-test-modules branch January 8, 2024 01:40
mergify bot pushed a commit that referenced this pull request Jan 8, 2024
* remove cl test modules

* remove from go work

(cherry picked from commit 2946424)

# Conflicts:
#	tests/cl-go-client/README.md
#	tests/cl-go-client/go.mod
#	tests/cl-go-client/go.sum
#	tests/cl-go-client/main.go
p0mvn pushed a commit that referenced this pull request Jan 8, 2024
* chore: remove cl test modules (#7254)

* remove cl test modules

* remove from go work

(cherry picked from commit 2946424)

# Conflicts:
#	tests/cl-go-client/README.md
#	tests/cl-go-client/go.mod
#	tests/cl-go-client/go.sum
#	tests/cl-go-client/main.go

* fix merge conflict

---------

Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
@github-actions github-actions bot mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v21.x backport patches to v21.x branch A:no-changelog C:docs Improvements or additions to documentation V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants