Speedup more stable swap math operations #7214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
added
V:state/compatible/backport
ValarDragon
requested review from
mattverse,
czarcas7ic,
p0mvn and
AlpinYukseloglu
as code owners
github-actions
bot
added
the
C:x/gamm
|
Important Notice This PR modifies an in-repo Go module. It is one of:
The dependent Go modules, especially the root one, will have to be Please follow the instructions below:
Please let us know if you need any help. |
|
It seems the failed test is related to the change, will wait to review until passing, unless you want me to look into it @ValarDragon |
|
Fixed! |
mattverse
approved these changes
Jan 2, 2024
| @@ -63,15 +63,16 @@ func targetKCalculator(x0, y0, w, yf osmomath.BigDec) osmomath.BigDec { | |||
| // $$k_{iter}(x_f) = -x_{out}^3 + 3 x_0 x_{out}^2 - (y_f^2 + w + 3x_0^2)x_{out}$$ | |||
| // where x_out = x_0 - x_f | |||
| func iterKCalculator(x0, w, yf osmomath.BigDec) func(osmomath.BigDec) osmomath.BigDec { | |||
| // compute coefficients first | |||
| cubicCoeff := osmomath.OneBigDec().Neg() | |||
| // compute coefficients first. Notice that the leading coefficient is -1, we will use this to compute faster. | |||
There was a problem hiding this comment.
note to other reviewers: x_{out}^3 remains same
Co-authored-by: Matt, Park <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Speedup more stable swap math operations * Try another speedup * revert one sigfig change * remove one more mutative operation * update osmomath * Update osmomath one more tiome * Update osmomath/decimal.go Co-authored-by: Matt, Park <[email protected]> --------- Co-authored-by: Matt, Park <[email protected]> (cherry picked from commit 9cd7231) # Conflicts: # go.mod # go.sum # osmomath/decimal.go # osmomath/decimal_test.go
mattverse
added a commit
that referenced
this pull request
Jan 9, 2024
* Speedup more stable swap math operations (#7214) * Speedup more stable swap math operations * Try another speedup * revert one sigfig change * remove one more mutative operation * update osmomath * Update osmomath one more tiome * Update osmomath/decimal.go Co-authored-by: Matt, Park <[email protected]> --------- Co-authored-by: Matt, Park <[email protected]> (cherry picked from commit 9cd7231) # Conflicts: # go.mod # go.sum # osmomath/decimal.go # osmomath/decimal_test.go * fix conflicts (still need to run action) * fix go mods to run script * go mod updates v21 instead of main --------- Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: mattverse <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speedup more stableswap math operations. Anticipated 2% speedup to CPU time of syncing