Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximum pool ID #7203

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Add maximum pool ID #7203

merged 2 commits into from
Dec 28, 2023

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Dec 24, 2023

makes a maximum pool ID of 100 billion - 1

This lets us make allocations for certain keys more efficient, that legacy use string formatting instead of uint64 representation.

At $1 to create a pool, this costs too much to ever be an issue. Let alone the $10 to $100 range governance currently seems to be in the mind of.

@czarcas7ic czarcas7ic merged commit 7bfcb0d into main Dec 28, 2023
1 check passed
@czarcas7ic czarcas7ic deleted the dev/add_max_pool_id branch December 28, 2023 23:21
@github-actions github-actions bot mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/poolmanager V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants