perf: avoid copy of period locks in epoch #7192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
V:state/compatible/backport
6 tasks
p0mvn
requested review from
mattverse,
czarcas7ic and
AlpinYukseloglu
as code owners
ValarDragon
reviewed
Dec 22, 2023
x/incentives/keeper/iterator.go
Outdated
| for _, lock := range locks { | ||
| if lock.Duration >= minDuration { | ||
| filteredLocks = append(filteredLocks, lock) | ||
| filteredLocks = append(filteredLocks, &lock) |
There was a problem hiding this comment.
Does this work? I thought this would have every filtered lock point to the same loop variable, not the copies in the original slice. (Which would be &locks[i])
There was a problem hiding this comment.
It synched through epoch but I applied the suggestion and rerunning pprof
There was a problem hiding this comment.
Looks like my suggstion doesnt work by go tests failing
There was a problem hiding this comment.
Force pushed an update that I think should work. Need to reprofile it now as it leads to having to take a copy of the pointer in another loop
There was a problem hiding this comment.
With the bug fix:
Still much better overall. I will now do a long-lasting test as opposed to epoch only
p0mvn
force-pushed
the
roman/avoid-copy-epoch
branch
from
3bd5551
to
de1c27c
Compare
|
Synching over many blocks. Will merge once ready |
ValarDragon
approved these changes
Dec 22, 2023
p0mvn
added a commit
that referenced
this pull request
Dec 22, 2023
Merged
p0mvn
added a commit
that referenced
this pull request
Dec 23, 2023
czarcas7ic
pushed a commit
that referenced
this pull request
Dec 29, 2023
czarcas7ic
added a commit
that referenced
this pull request
Dec 30, 2023
* Reduce discrepancy in fee simulation * Update * State compatible applyFuncIfNoError event reduction * Update osmoutils/epochs versions * Update SDK version * One more epoch speedup * Speedup core loop of epoch * fix test (#7197) * refactor: auto-set timeout-commit to 4s for faster block times (#7196) * updates (#7192) * refactor: auto-set timeout-commit to 4s for faster block times (backport #7180) * changelog * Revert "updates (#7192)" This reverts commit 6cc26f9. * lint * Update changelog * Update changelog * changelog * Speedup multiplication * Try scratch slice * refactor: arb filter for new authz exec swap (#7210) * refactor: arb filter for new authz exec swap * updates * updates * updates * clean up * Auto: update go.mod after push to adam/v21.1.x-merge-to-main that modified dependencies locally * add 21.1.5 to changelog * update comment --------- Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Roman <[email protected]> Co-authored-by: github-actions <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Dec 30, 2023
* Reduce discrepancy in fee simulation * Update * State compatible applyFuncIfNoError event reduction * Update osmoutils/epochs versions * Update SDK version * One more epoch speedup * Speedup core loop of epoch * fix test (#7197) * refactor: auto-set timeout-commit to 4s for faster block times (#7196) * updates (#7192) * refactor: auto-set timeout-commit to 4s for faster block times (backport #7180) * changelog * Revert "updates (#7192)" This reverts commit 6cc26f9. * lint * Update changelog * Update changelog * changelog * Speedup multiplication * Try scratch slice * refactor: arb filter for new authz exec swap (#7210) * refactor: arb filter for new authz exec swap * updates * updates * updates * clean up * Auto: update go.mod after push to adam/v21.1.x-merge-to-main that modified dependencies locally * add 21.1.5 to changelog * update comment --------- Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Roman <[email protected]> Co-authored-by: github-actions <[email protected]> (cherry picked from commit c5a5147) # Conflicts: # go.mod # go.sum # osmomath/go.sum
czarcas7ic
added a commit
that referenced
this pull request
Dec 30, 2023
* chore: catch up main to v21.1.x (#7215) * Reduce discrepancy in fee simulation * Update * State compatible applyFuncIfNoError event reduction * Update osmoutils/epochs versions * Update SDK version * One more epoch speedup * Speedup core loop of epoch * fix test (#7197) * refactor: auto-set timeout-commit to 4s for faster block times (#7196) * updates (#7192) * refactor: auto-set timeout-commit to 4s for faster block times (backport #7180) * changelog * Revert "updates (#7192)" This reverts commit 6cc26f9. * lint * Update changelog * Update changelog * changelog * Speedup multiplication * Try scratch slice * refactor: arb filter for new authz exec swap (#7210) * refactor: arb filter for new authz exec swap * updates * updates * updates * clean up * Auto: update go.mod after push to adam/v21.1.x-merge-to-main that modified dependencies locally * add 21.1.5 to changelog * update comment --------- Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Roman <[email protected]> Co-authored-by: github-actions <[email protected]> (cherry picked from commit c5a5147) # Conflicts: # go.mod # go.sum # osmomath/go.sum * go mod update * update go mods from v21.x --------- Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Adam Tucker <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
This speeds up epoch by avoiding copying stemming from period locks
New:
Old:
Testing and Verifying
Synched over epoch + 150 blocks.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)