refactor: replace MinCoins with sdk coins.Min() #7127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levisyin
requested review from
mattverse,
czarcas7ic,
p0mvn and
AlpinYukseloglu
as code owners
github-actions
bot
added
C:x/gamm
p0mvn
approved these changes
Dec 15, 2023
p0mvn
added
V:state/compatible/no_backport
p0mvn
added
V:state/compatible/backport
mattverse
approved these changes
Dec 18, 2023
|
Hi @mattverse sir, is there anything else need I to add or can we get this merged😀 |
|
@p0mvn Hi sir, can we get this merged😀 |
czarcas7ic
added
V:state/compatible/no_backport
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
* refactor: replace MinCoins with sdk coins.Min() * fix: remove unused import (cherry picked from commit ccd1865) # Conflicts: # osmoutils/coin_helper.go
p0mvn
pushed a commit
that referenced
this pull request
Jan 9, 2024
* refactor: replace MinCoins with sdk coins.Min() (#7127) * refactor: replace MinCoins with sdk coins.Min() * fix: remove unused import (cherry picked from commit ccd1865) # Conflicts: # osmoutils/coin_helper.go * Fix merge conflict --------- Co-authored-by: levisyin <[email protected]> Co-authored-by: mattverse <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
MinCoinscould be replaced bycoins.Min(), this PR replaces all reference of usingMinCoinstocoins.Min()