Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower Epoch CPU usage #7093

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Lower Epoch CPU usage #7093

merged 1 commit into from
Dec 12, 2023

Conversation

ValarDragon
Copy link
Member

Some state compatible speedups for lowering Epoch CPU usage!

  • Removes an expensive log line for every single lock
  • Removes two Heap allocations from the core loop taking CPU time here

Its not the easiest to gather quite what the speedup percentage for the whole system is, and not even for CPU time as a whole. It seems minor, e.g. I'd expect this to be shaving like 500ms off epoch, but could be more impactful. Very not simple to tell.

@ValarDragon ValarDragon added V:state/compatible/backport State machine compatible PR, should be backported A:no-changelog A:backport/v21.x backport patches to v21.x branch labels Dec 12, 2023
@ValarDragon ValarDragon merged commit 54883e0 into main Dec 12, 2023
1 check passed
@ValarDragon ValarDragon deleted the dev/speedup_epoch_state_compatible branch December 12, 2023 17:50
@ValarDragon ValarDragon added the A:backport/v20.x backport patches to v20.x branch label Dec 12, 2023
mergify bot pushed a commit that referenced this pull request Dec 12, 2023
(cherry picked from commit 54883e0)
mergify bot pushed a commit that referenced this pull request Dec 12, 2023
(cherry picked from commit 54883e0)
ValarDragon added a commit that referenced this pull request Dec 12, 2023
(cherry picked from commit 54883e0)

Co-authored-by: Dev Ojha <[email protected]>
ValarDragon added a commit that referenced this pull request Dec 12, 2023
(cherry picked from commit 54883e0)

Co-authored-by: Dev Ojha <[email protected]>
ValarDragon added a commit that referenced this pull request Dec 20, 2023
(cherry picked from commit 54883e0)

Co-authored-by: Dev Ojha <[email protected]>
ValarDragon added a commit that referenced this pull request Dec 21, 2023
(cherry picked from commit 54883e0)

Co-authored-by: Dev Ojha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v20.x backport patches to v20.x branch A:backport/v21.x backport patches to v21.x branch A:no-changelog C:x/incentives C:x/lockup V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants