-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gorocksdb #704
gorocksdb #704
Conversation
Codecov Report
@@ Coverage Diff @@
## main #704 +/- ##
=======================================
Coverage 18.69% 18.69%
=======================================
Files 171 171
Lines 23814 23814
=======================================
Hits 4452 4452
Misses 18600 18600
Partials 762 762 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll fix merge conflicts with marko's PR for removing replaces and get it merged
Can you give me write access to PRs to main 😅 |
There maybe some wierd things for allowing maintainers to commit to an organization. If so, can you just cherry-pick thee two commits:
and we can get it merged? |
going to push fix in second branch, so it gets in! I imagine your stacked in other things rn |
oh hey sorry! thank you! |
Description
This is a simple fix that makes osmosis work properly with rocksdb.
#695
It also bumps:
For contributor use:
docs/
) or specification (x/<module>/spec/
)Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer