Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: taker fee query via grpc gateway #6939

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix: taker fee query via grpc gateway #6939

merged 2 commits into from
Nov 28, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Nov 28, 2023

Closes: #XXX

What is the purpose of the change

Fixes taker fee query path. Currently, it doesn't work due to overlapping with the pools path.

Testing and Verifying

Tested on a v20 node

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v20.x backport patches to v20.x branch labels Nov 28, 2023
@p0mvn p0mvn marked this pull request as ready for review November 28, 2023 18:51
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@p0mvn p0mvn merged commit 5fc1353 into main Nov 28, 2023
1 check passed
@p0mvn p0mvn deleted the roman/fix-taker-fee-query branch November 28, 2023 19:06
mergify bot pushed a commit that referenced this pull request Nov 28, 2023
* fix: taker fee query via grpc gateway

* changelog

(cherry picked from commit 5fc1353)

# Conflicts:
#	CHANGELOG.md
#	x/poolmanager/client/queryproto/query.pb.go
p0mvn added a commit that referenced this pull request Nov 28, 2023
* fix: taker fee query via grpc gateway (#6939)

* fix: taker fee query via grpc gateway

* changelog

(cherry picked from commit 5fc1353)

# Conflicts:
#	CHANGELOG.md
#	x/poolmanager/client/queryproto/query.pb.go

* Generated protofile changes

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Roman <[email protected]>
Co-authored-by: github-actions <[email protected]>
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge A:backport/v20.x backport patches to v20.x branch C:CLI C:x/poolmanager V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants