Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(incentives): remove redundant param from CreateGaugeRefKeys #6511

Merged
merged 3 commits into from
Sep 24, 2023
Merged

refactor(incentives): remove redundant param from CreateGaugeRefKeys #6511

merged 3 commits into from
Sep 24, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Sep 23, 2023

Closes: #XXX

What is the purpose of the change

Removes redundant param. Will backport and test for state compatibility

@p0mvn
Copy link
Member Author

p0mvn commented Sep 23, 2023

@devbot-wizard help

@devbot-wizard
Copy link
Collaborator

Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:

  • devbot fix: Fix basic errors in the PR. (e.g. imports, changelog conflicts, go mod conflicts)
  • devbot merge base: Merge the base branch into the PR branch.
  • devbot add changelog [misc/feat/bug/api/sec] [message]: Add a changelog entry to the PR. (e.g. devbot add changelog feat Added a new feature)
    • If message is blank, defaults to PR title.
  • devbot re-pr: Re-PR the PR, useful for external contributors where we have no edit perms.

@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v19.x backport patches to v19.x branch and removed C:x/incentives labels Sep 23, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Sep 23, 2023

devbot add changelog api remove redundant param from CreateGaugeRefKeys in incentives

@p0mvn p0mvn marked this pull request as ready for review September 23, 2023 20:35
AlpinYukseloglu
AlpinYukseloglu approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@AlpinYukseloglu AlpinYukseloglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@p0mvn p0mvn merged commit 1e83ec9 into main Sep 24, 2023
1 check passed
@p0mvn p0mvn deleted the roman/redundant-param2 branch September 24, 2023 12:00
mergify bot pushed a commit that referenced this pull request Sep 24, 2023
@p0mvn @mergify
refactor(incentives): remove redundant param from CreateGaugeRefKeys (#…
9d5e4c0 
…6511)

* refactor(incentives): remove redundant param from CreateGaugeRefKeys

* update changelog

---------

Co-authored-by: devbot-wizard <[email protected]>
(cherry picked from commit 1e83ec9)

# Conflicts:
#	CHANGELOG.md
#	x/incentives/keeper/gauge.go
@mergify mergify bot mentioned this pull request Sep 24, 2023
Merged
p0mvn added a commit that referenced this pull request Sep 26, 2023
@p0mvn
refactor(incentives): remove redundant param from CreateGaugeRefKeys …
f60c033 
…(backport #6511)
p0mvn added a commit that referenced this pull request Sep 26, 2023
@mergify @p0mvn
refactor(incentives): remove redundant param from CreateGaugeRefKeys …
86c12df 
…(backport #6511) (#6516)

Co-authored-by: roman <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlpinYukseloglu AlpinYukseloglu AlpinYukseloglu approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

Assignees
No one assigned
Labels
A:backport/v19.x backport patches to v19.x branch C:x/incentives V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0mvn @devbot-wizard @AlpinYukseloglu