fix/test/docs: negative interval accumulation with spread rewards #5869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:docs
6 tasks
|
Lgtm on first pass! Will review test changes in more detail later. |
czarcas7ic
approved these changes
Jul 24, 2023
ValarDragon
reviewed
Jul 28, 2023
ValarDragon
approved these changes
Jul 31, 2023
|
We may have to fix the osmoutils version if E2E fails |
AlpinYukseloglu
approved these changes
Jul 31, 2023
| if the current tick >= tick. As a result, when subtracting the lower tick snapshot from the upper, | ||
| the lower one is greater than or equal to the upper. | ||
|
|
||
| This is not an issue because it gets canceled out by the "interval accumulation outside at time t'" that is added to |
There was a problem hiding this comment.
Perhaps the more important point here is that the accumulator value is still always strictly increasing, meaning that the diff between the values at t' and t are always positive.
This alone should be sufficient to make the feature sound, regardless of whether the initial negative value is ever "canceled out"
| @@ -1244,6 +1244,76 @@ func (k Keeper) collectSpreadRewards( | |||
|
|
|||
| This returns the amount of spread rewards collected by the user. | |||
|
|
|||
| ## Interval Accumulation | |||
6 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #5854
What is the purpose of the change
This PR fixes a negative interval accumulation edge case bug by simply replacing
SubwithSafeSubwhere applicable.The tests are extended to cover claiming rewards below, inside, and above the position after it is initialized.
Note, that incentive rewards still need to be tested and potentially fixed. This PR only covers spread rewards.
Testing and Verifying
The global invariants are asserted, and the tests ensure that the appropriate amount is claimed from all positions in all cases.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)