feat: cosmwasmpool core logic and tests #5354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaslara
reviewed
May 31, 2023
nicolaslara
reviewed
May 31, 2023
nicolaslara
reviewed
May 31, 2023
| // represents a pool that was stored in the keeper. | ||
| // - An error if unmarshalling fails for any of the values fetched from the store. | ||
| // In this case, the slice of PoolI interfaces will be nil. | ||
| func (k Keeper) GetPools(ctx sdk.Context) ([]poolmanagertypes.PoolI, error) { |
There was a problem hiding this comment.
who can call this? I'm concerned about performance as this is a linear operation. Right now this is probably limited by the whitelist, but if we open it up it may be a problem.
There was a problem hiding this comment.
This is currently exposed as a query to frontend. For every pool module, we have a similar query. x/poolmanager exposes an AllPools query that gets pools from every module. This is not an issue.
However, we should avoid exposing this to stargate whitelist
nicolaslara
reviewed
May 31, 2023
nicolaslara
approved these changes
May 31, 2023
github-actions
bot
added
C:x/concentrated-liquidity
C:x/gamm
|
Addressed all comments. Going to merge once CI passes. Thanks @nicolaslara |
pysel
pushed a commit
that referenced
this pull request
Jun 6, 2023
* feat: cosmwasmpool core logic and tests * changelog * updates * updates * rename cast helpers * rename * remove error check
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
This is the core logic and full integration of
x/cosmwasmpoolinto the rest of the system.It is tested with the version of transmuter contract as of
mainbranch here: https://github.com/osmosis-labs/transmuterSpec: https://github.com/osmosis-labs/osmosis/tree/main/x/cosmwasmpool
The remaining steps are:
Testing and Verifying
This change added tests
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)