Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CL][InternalReview] MsgAddToConcentratedLiquiditySuperfluidPosition #5157
[CL][InternalReview] MsgAddToConcentratedLiquiditySuperfluidPosition #5157
Changes from 13 commits
617dd99
0fd0f60
c5580b4
4f94481
aa051c6
e946c8c
24993a8
21abb27
b422ece
6d9ef97
615fa4f
5cd8956
9a3a9d5
402eb25
ccc2d88
712ad32
19c92c2
facba8a
09af62b
8599d6a
183cf83
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: would like to confirm with reviewers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only potential issue I can see with this is if we had a 100 percent risk factor, which I am fairly certain we will never do.
Also, even if we did, it would result in the position getting very slightly under slashed, which I also do not think is innately dangerous.
Good call out though. Maybe we add a note to risk factor pointing to this on why we wouldn't want 1:1 ratio for superfluid minting.