Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jl/add in and out coins to cl swap listener #4950

Merged
merged 6 commits into from
May 26, 2023
Merged

Jl/add in and out coins to cl swap listener #4950

merged 6 commits into from
May 26, 2023

Conversation

NotJeremyLiu
Copy link
Contributor

@NotJeremyLiu NotJeremyLiu commented Apr 18, 2023 •
edited
Loading

Closes: #4945

What is the purpose of the change

  • To add the input and output coins associated with a concentrated liquidity pool swap to the AfterConcentratedPoolSwap listener.
  • This will be used in ProtoRev to move to a hook-based logic of extracting swapped pools when backrunning transactions.
  • Designs follows how the GAMM module's AfterCFMMSwap hook is implemented

Brief Changelog

  • Added two more values given in the CL AfterConcentratedPoolSwap listener: input and output coins
  • Updated modules that use the listener

Testing and Verifying

  • All tests still pass
  • No new tests added

Documentation and Release Note

  • No new documentation added

@NotJeremyLiu
Add input and output
02ddd55 
- Follows gamm module patterns such as 1) naming convention and 2) providing tokens (sdk.Coins) even though it's currently expected to be a single token in or out (sdk.Coin).
@NotJeremyLiu
Update modules that use hook
75ea9cc
@NotJeremyLiu NotJeremyLiu added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks protorev All things related to x/protorev labels Apr 18, 2023
@NotJeremyLiu NotJeremyLiu marked this pull request as ready for review April 18, 2023 06:40
@NotJeremyLiu NotJeremyLiu mentioned this pull request Apr 24, 2023
Closed
3 tasks
czarcas7ic
czarcas7ic approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label May 17, 2023
@github-actions github-actions bot removed the Stale label May 18, 2023
@czarcas7ic czarcas7ic merged commit fd3f811 into main May 26, 2023
@czarcas7ic czarcas7ic deleted the jl/add-in-and-out-coins-to-cl-swap-listener branch May 26, 2023 15:17
pysel pushed a commit that referenced this pull request Jun 6, 2023
@NotJeremyLiu @pysel
Jl/add in and out coins to cl swap listener (#4950)
b358282 
* Add input and output

- Follows gamm module patterns such as 1) naming convention and 2) providing tokens (sdk.Coins) even though it's currently expected to be a single token in or out (sdk.Coin).

* Update modules that use hook

* add changelog entry
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@nicolaslara nicolaslara Awaiting requested review from nicolaslara nicolaslara is a code owner

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn is a code owner

Assignees
No one assigned
Labels
C:x/concentrated-liquidity C:x/pool-incentives C:x/twap Changes to the twap module protorev All things related to x/protorev V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat Request for ProtoRev: Add input/output coins to CL Swap listener
2 participants
@NotJeremyLiu @czarcas7ic