Enable CORS on localosmosis #4891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niccoloraspa
added
V:state/compatible/backport
|
cc: @jonator |
p0mvn
approved these changes
Apr 11, 2023
ValarDragon
approved these changes
Apr 11, 2023
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
Closes: [#4879](#4879) ## What is the purpose of the change Enables cors on localOsmosis for: - rpc - api - gRPC-web ## Brief Changelog - Enable cors by default on localosmosis ## Testing and Verifying Start localosmosis: ```bash make localnet-start ``` Check file changes: ```bash ❯ cat ~/.osmosisd-local/config/config.toml | grep cors cors_allowed_headers = ["Origin", "Accept", "Content-Type", "X-Requested-With", "X-Server-Time", "Accept-Encoding"] cors_allowed_methods = ["HEAD", "GET", "POST", "DELETE", "OPTIONS", "PATCH", "PUT"] cors_allowed_origins = ["*"] ``` ```bash ❯ cat ~/.osmosisd-local/config/app.toml | grep cors enabled-unsafe-cors = true enable-unsafe-cors = true ``` ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? no - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? yes - How is the feature or change documented? not applicable (cherry picked from commit 3b2e168) # Conflicts: # CHANGELOG.md # tests/localosmosis/scripts/setup.sh
niccoloraspa
added a commit
that referenced
this pull request
Apr 12, 2023
* Enable CORS on localosmosis (#4891) Closes: [#4879](#4879) ## What is the purpose of the change Enables cors on localOsmosis for: - rpc - api - gRPC-web ## Brief Changelog - Enable cors by default on localosmosis ## Testing and Verifying Start localosmosis: ```bash make localnet-start ``` Check file changes: ```bash ❯ cat ~/.osmosisd-local/config/config.toml | grep cors cors_allowed_headers = ["Origin", "Accept", "Content-Type", "X-Requested-With", "X-Server-Time", "Accept-Encoding"] cors_allowed_methods = ["HEAD", "GET", "POST", "DELETE", "OPTIONS", "PATCH", "PUT"] cors_allowed_origins = ["*"] ``` ```bash ❯ cat ~/.osmosisd-local/config/app.toml | grep cors enabled-unsafe-cors = true enable-unsafe-cors = true ``` ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? no - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? yes - How is the feature or change documented? not applicable (cherry picked from commit 3b2e168) # Conflicts: # CHANGELOG.md # tests/localosmosis/scripts/setup.sh * Update CHANGELOG.md * Align setup.sh * Update create_two_asset_pool() --------- Co-authored-by: Niccolo Raspa <[email protected]> Co-authored-by: Niccolo Raspa <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4879
What is the purpose of the change
Enables cors on localOsmosis for:
Brief Changelog
Testing and Verifying
Start localosmosis:
Check file changes:
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes