Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CL): x/poolmanager spot price query for concentrated liquidity #4682

Merged
merged 8 commits into from
Mar 22, 2023
Merged

feat(CL): x/poolmanager spot price query for concentrated liquidity #4682

merged 8 commits into from
Mar 22, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Mar 20, 2023 •
edited
Loading

Closes: https://app.clickup.com/t/860pq0nxv

What is the purpose of the change

The current spot price query in x/gamm only allows for getting balancer and stableswap spot prices.

The data team needs a unified entrypoint for all pools. As a result, we are deprecating x/gamm spot price query and moving it to x/poolmanager.

This will also enable querying spot price for any future pool such as #4675

Brief Changelog

  • deprecate spot price query
  • code-gen pool manager query
  • the keeper is already wired up to CL

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?yes
  • How is the feature or change documented? not applicable

@github-actions github-actions bot added C:CLI C:x/gamm Changes, features and bugs related to the gamm module. C:x/poolmanager labels Mar 20, 2023
@p0mvn p0mvn added the V:state/breaking State machine breaking PR label Mar 20, 2023
@p0mvn p0mvn marked this pull request as ready for review March 20, 2023 19:19
@p0mvn p0mvn closed this Mar 20, 2023
@p0mvn p0mvn reopened this Mar 20, 2023
mattverse
mattverse approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on moving the spot price query as well to have it depend on pool manager. LGTM

@p0mvn p0mvn merged commit 9303268 into main Mar 22, 2023
@p0mvn p0mvn deleted the roman/poolmanager-spot-price branch March 22, 2023 22:21
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic czarcas7ic is a code owner

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

@stackman27 stackman27 Awaiting requested review from stackman27

Assignees
No one assigned
Labels
C:CLI C:x/gamm Changes, features and bugs related to the gamm module. C:x/poolmanager V:state/breaking State machine breaking PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @mattverse