Tokenfactory: Add Before send hooks #4382
Conversation
github-actions
bot
added
C:app-wiring
mattverse
added
the
V:state/compatible/backport
| @@ -63,6 +66,8 @@ message MsgBurn { | |||
| (gogoproto.moretags) = "yaml:\"amount\"", | |||
| (gogoproto.nullable) = false | |||
| ]; | |||
| string burnFromAddress = 3 | |||
There was a problem hiding this comment.
this is not related to the send hooks, right? Do we need these mint/burn changes?
There was a problem hiding this comment.
good catch! Srry meant to address this in a different PR must have been pushed together. Fixed
|
|
||
| em := sdk.NewEventManager() | ||
|
|
||
| _, err = h.wasmkeeper.Sudo(ctx.WithEventManager(em), cwAddr, msgBz) |
There was a problem hiding this comment.
We probably want to think about gas increase expectations for bank sends with tokenfactory denoms as the contract can consume unbounded gas
There was a problem hiding this comment.
Do you think its a possible option to gate usage of gas here?
There was a problem hiding this comment.
yeah, we've been discussing something similar for wasm-hooks: (#4195). For the ibc case, I think non-atomic multimsg is enough, but for send hooks I think we may want to have a hard-cap on how much gas those hooks are allowed to take (something like: https://github.com/cosmos/ibc-go/blob/main/modules/core/keeper/msg_server.go#L451) and have users submit with that limit.
There is no risk to the chain here though, it's more of a UX problem. If a contract (by malice or incompetence) has an infinite loop or just very high gas usage, users may need to submit their tx with increasing gas limits
There was a problem hiding this comment.
I see I see, sounds fine for now for the UX tradeoff of gas problem, going ahead and merging this for now
x/tokenfactory/keeper/keeper_test.go
Outdated
| func (suite *KeeperTestSuite) SetupTest() { | ||
| suite.Setup() | ||
| // Fund every TestAcc with two denoms, one of which is the denom creation fee | ||
| fundAccsAmount := sdk.NewCoins(sdk.NewCoin(types.DefaultParams().DenomCreationFee[0].Denom, types.DefaultParams().DenomCreationFee[0].Amount.MulRaw(100)), sdk.NewCoin(apptesting.SecondaryDenom, apptesting.SecondaryAmount)) | ||
| for _, acc := range suite.TestAccs { | ||
| suite.FundAcc(acc, fundAccsAmount) | ||
| } | ||
|
|
||
| suite.contractKeeper = wasmkeeper.NewPermissionedKeeper(suite.App.WasmKeeper, SudoAuthorizationPolicy{}) |
There was a problem hiding this comment.
NewGovPermissionKeeper should already do what SudoAuthorizationPolicy is doing
There was a problem hiding this comment.
sweet, replaced this with NewGovPermissionKeeper
What is the purpose of the change
Adds BeforeSend hooks to token factory.
Background: We want to enable calls to cosmwasm contracts before send of a token factory denom.
We have registered
BeforeSendhooks to the cosmos sdk a while ago, this PR implements the BeforeSend hook to the token factory module.Whenever the before send hook in token factory is called, we check in state if a contract address has been registered for the specific denom being sent. If so, the contract is called before send via hooks.
Brief Changelog
Testing and Verifying
This change adds tests
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)