Fix stableswap use of osmomath #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaslara
added
the
V:state/compatible/no_backport
p0mvn
approved these changes
Jan 3, 2023
| @@ -144,7 +144,7 @@ func (e ErrTolerance) CompareBigDec(expected BigDec, actual BigDec) int { | |||
| // Binary search inputs between [lowerbound, upperbound] to a monotonic increasing function f. | |||
| // We stop once f(found_input) meets the ErrTolerance constraints. | |||
| // If we perform more than maxIterations (or equivalently lowerbound = upperbound), we return an error. | |||
| func BinarySearch(f func(input sdk.Int) (sdk.Int, error), | |||
| func BinarySearch(f func(sdk.Int) (sdk.Int, error), | |||
There was a problem hiding this comment.
I don't think this makes a difference because #3904 tags main directly and passes CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
2ac5d35 breaks stableswap because osmomath requires the users of the binsearch functions to use the name
inputfor the function's argument. This removes that requirementBrief Changelog
Make function used by binary search on osmomath more flexible
Testing and Verifying
All tests continue to pass
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)