Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add negative to cli #3888

Merged
merged 1 commit into from
Dec 30, 2022
Merged

fix: add negative to cli #3888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions osmoutils/osmocli/parsers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,14 @@ func parseFieldFromDirectlySetFlag(fVal reflect.Value, fType reflect.StructField
}

func ParseFieldFromArg(fVal reflect.Value, fType reflect.StructField, arg string) error {
// We cant pass in a negative number due to the way pflags works...
// This is an (extraordinarily ridiculous) workaround that checks if a negative int is encapsulated in square brackets,
// and if so, trims the square brackets
if strings.HasPrefix(arg, "[") && strings.HasSuffix(arg, "]") && arg[1] == '-' {
arg = strings.TrimPrefix(arg, "[")
arg = strings.TrimSuffix(arg, "]")
}

switch fType.Type.Kind() {
// SetUint allows anyof type u8, u16, u32, u64, and uint
case reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uint:
Expand Down