Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move binary search from osmomath to osmoutils #3763

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Conversation

ValarDragon
Copy link
Member

Closes: #3251 , cref #3744

What is the purpose of the change

Context in issues

Brief Changelog

Move binary search from osmoutils into osmomath

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? n/a

@ValarDragon ValarDragon added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v13.x backport patches to v13.x branch labels Dec 16, 2022
@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Dec 16, 2022
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ValarDragon ValarDragon merged commit 3095a7d into main Dec 16, 2022
@ValarDragon ValarDragon deleted the dev/move_binary_search branch December 16, 2022 18:14
mergify bot pushed a commit that referenced this pull request Dec 16, 2022
* Move binary search from osmomath to osmoutils

* Add changelog

(cherry picked from commit 3095a7d)

# Conflicts:
#	osmomath/binary_search.go
#	x/gamm/pool-models/balancer/pool_test.go
#	x/gamm/pool-models/internal/cfmm_common/lp.go
#	x/gamm/pool-models/stableswap/amm.go
#	x/gamm/pool-models/stableswap/amm_test.go
ValarDragon added a commit that referenced this pull request Dec 16, 2022
* Move binary search from osmomath to osmoutils (#3763)

* Move binary search from osmomath to osmoutils

* Add changelog

(cherry picked from commit 3095a7d)

# Conflicts:
#	osmomath/binary_search.go
#	x/gamm/pool-models/balancer/pool_test.go
#	x/gamm/pool-models/internal/cfmm_common/lp.go
#	x/gamm/pool-models/stableswap/amm.go
#	x/gamm/pool-models/stableswap/amm_test.go

* Fix conflict

Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Dev Ojha <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v13.x backport patches to v13.x branch C:x/gamm Changes, features and bugs related to the gamm module. V:state/compatible/backport State machine compatible PR, should be backported
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move binary search to its own package
3 participants