Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pagination to Pool With Filter Query (backport #3563) #3572

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 30, 2022

This is an automatic backport of pull request #3563 done by Mergify.
Cherry-pick of 1dedc28 has failed:

On branch mergify/bp/v12.x/pr-3563
Your branch is up to date with 'origin/v12.x'.

You are currently cherry-picking commit 1dedc28c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   proto/osmosis/gamm/v1beta1/query.proto
	both modified:   x/gamm/keeper/grpc_query.go
	both modified:   x/gamm/types/query.pb.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Add Pagination to filter pool query

* Use Filtered Pagination

* Add logic for offset in pagination

* Return false on response

* Bug fix

* Refactors for clean code

* Remove snake cases

* Fix typos

* Clean more code

(cherry picked from commit 1dedc28)

# Conflicts:
#	proto/osmosis/gamm/v1beta1/query.proto
#	x/gamm/keeper/grpc_query.go
#	x/gamm/types/query.pb.go
@mergify mergify bot requested a review from a team November 30, 2022 05:21
@mergify mergify bot added the conflicts label Nov 30, 2022
@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Nov 30, 2022
@ValarDragon ValarDragon closed this Dec 2, 2022
@ValarDragon ValarDragon deleted the mergify/bp/v12.x/pr-3563 branch December 2, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. conflicts
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants