Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keeper level panic catches #3312

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Add keeper level panic catches #3312

merged 3 commits into from
Nov 9, 2022

Conversation

ValarDragon
Copy link
Member

Closes: #3277

What is the purpose of the change

Panic catch keeper operations

Brief Changelog

  • panic catch keeper operations

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? Code comments

@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Nov 9, 2022
@ValarDragon ValarDragon added V:state/breaking State machine breaking PR A:backport/v13.x backport patches to v13.x branch labels Nov 9, 2022
@ValarDragon ValarDragon marked this pull request as ready for review November 9, 2022 19:48
@ValarDragon ValarDragon requested a review from a team November 9, 2022 19:48
AlpinYukseloglu
AlpinYukseloglu approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@AlpinYukseloglu AlpinYukseloglu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we also be catching panics for swap functions since they all route through our solver which can trigger panics?

@ValarDragon
Copy link
Member Author

Ah yes, thank you I missed that

@ValarDragon ValarDragon merged commit f88577d into main Nov 9, 2022
@ValarDragon ValarDragon deleted the dev/keeper_level_panic_catch branch November 9, 2022 23:27
@mergify mergify bot mentioned this pull request Nov 9, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 9, 2022
@ValarDragon @mergify
Add keeper level panic catches (#3312)
8bd01d8 
* Add keeper level panic catches

* Add changelog

* Add panic catch for swap

(cherry picked from commit f88577d)
ValarDragon added a commit that referenced this pull request Nov 9, 2022
@mergify @ValarDragon
Add keeper level panic catches (#3312) (#3315)
54fc604 
* Add keeper level panic catches

* Add changelog

* Add panic catch for swap

(cherry picked from commit f88577d)

Co-authored-by: Dev Ojha <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlpinYukseloglu AlpinYukseloglu AlpinYukseloglu approved these changes

Assignees
No one assigned
Labels
A:backport/v13.x backport patches to v13.x branch C:x/gamm Changes, features and bugs related to the gamm module. V:state/breaking State machine breaking PR
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[x/gamm][stableswap]: Panic catch core operations at keeper level
2 participants
@ValarDragon @AlpinYukseloglu