Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CalcJoinPoolShares and CalcExitPoolCoinsFromShares pool queries to Stargate whitelist #3217

Merged
merged 91 commits into from
Nov 15, 2022

Conversation

georgemc98
Copy link
Contributor

@georgemc98 georgemc98 commented Nov 2, 2022

Related to #2956 and dependent on PR #2972

What is the purpose of the change

This PR adds the CalcJoinPoolShares and CalcExitPoolCoinsFromShares queries added in PR #2972 to the whitelisted Stargate queries in the wasmbindings.

Brief Changelog

(for example:)

  • Add CalcJoinPoolShares query to whitelisted Stargate queries
  • Add CalcExitPoolCoinsFromShares query to whitelisted Stargate queries

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not documented

@github-actions github-actions bot added the T:CI label Nov 14, 2022
x/gamm/keeper/export_test.go Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the C:x/gamm Changes, features and bugs related to the gamm module. label Nov 14, 2022
@georgemc98
Copy link
Contributor Author

@p0mvn I changed the workflow files to match what is in main. This PR should be good to go now

@georgemc98
Copy link
Contributor Author

@p0mvn Is there anything else I should do to get this merged in?

@p0mvn p0mvn added the A:backport/v13.x backport patches to v13.x branch label Nov 15, 2022
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Matt, Park <[email protected]>
@p0mvn p0mvn merged commit 03ec730 into osmosis-labs:main Nov 15, 2022
mergify bot pushed a commit that referenced this pull request Nov 15, 2022
…o Stargate whitelist (#3217)

* TotalDelegationByValidatorForAsset query + tests

* TotalDelegationByValidatorForAsset + tests

* TotalDelegationByValidatorForAsset + test

* names changed

* save

* TotalDelegationByValidatorForDenom query

* TotalDelegationByValidatorForDenom

* JoinSwapExactAmountIn query

* ExitSwapShareAmountIn query

* JoinSwapExactAmountIn, ExitSwapShareAmountIn queries

* JoinSwapExactAmountIn, ExitSwapShareAmountIn queries

* JoinSwapExactAmountIn, ExitSwapShareAmountIn queries

* JoinSwapExactAmountIn, ExitSwapShareAmountIn queries

* JoinSwapExactAmountIn, ExitSwapShareAmountIn queries

* JoinSwapExactAmountIn, ExitSwapShareAmountIn queries

* save

* test: finish CalcJoinPoolShares query test

* tests for CalcExitPoolCoinsFromShares

* tests for CalcExitPoolCoinsFromShares

* save

* test: add additional exit coin tests

* docs rpc TotalDelegationByValidatorForDenom

* TotalDelegationByValidatorForDenom clean

* TotalDelegationByValidatorForDenom query

* TotalDelegationByValidatorForDenom query

* TotalDelegationByValidatorForDenom query

* query

* save

* Update x/gamm/keeper/grpc_query.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update x/gamm/keeper/grpc_query.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update x/gamm/keeper/grpc_query.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* queries

* docs fix

* feat: add two pool shares queries to stargate whitelist

* chore: update changelog

* feat: generate proto files

* chore: generate proto files

* autocli copy from cosmos

* reset

* save

* SimJoinPoolNoSwap

* docs

* JoinPoolNoSwap simulation

* more fixes

* fix docs and name

* fix: change tokens_in type

* test: fix TestCalcJoinPoolNoSwapShares test

* feat: build query.pb.go file

* name version >>

* update action v

* check variable

* action from personal fork

* remove tag

* chore: remove whitespace

Co-authored-by: Roman <[email protected]>

* chore: workflow files

* chore: fix docker.yml file

* chore: fix required_labels.yml

* chore: remove space

* Update CHANGELOG.md

Co-authored-by: Matt, Park <[email protected]>

Co-authored-by: Ruslan Akhtariev <[email protected]>
Co-authored-by: Ruslan Akhtariev <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Matt, Park <[email protected]>
(cherry picked from commit 03ec730)
p0mvn pushed a commit that referenced this pull request Nov 15, 2022
…o Stargate whitelist (#3217) (#3385)

* TotalDelegationByValidatorForAsset query + tests

* TotalDelegationByValidatorForAsset + tests

* TotalDelegationByValidatorForAsset + test

* names changed

* save

* TotalDelegationByValidatorForDenom query

* TotalDelegationByValidatorForDenom

* JoinSwapExactAmountIn query

* ExitSwapShareAmountIn query

* JoinSwapExactAmountIn, ExitSwapShareAmountIn queries

* JoinSwapExactAmountIn, ExitSwapShareAmountIn queries

* JoinSwapExactAmountIn, ExitSwapShareAmountIn queries

* JoinSwapExactAmountIn, ExitSwapShareAmountIn queries

* JoinSwapExactAmountIn, ExitSwapShareAmountIn queries

* JoinSwapExactAmountIn, ExitSwapShareAmountIn queries

* save

* test: finish CalcJoinPoolShares query test

* tests for CalcExitPoolCoinsFromShares

* tests for CalcExitPoolCoinsFromShares

* save

* test: add additional exit coin tests

* docs rpc TotalDelegationByValidatorForDenom

* TotalDelegationByValidatorForDenom clean

* TotalDelegationByValidatorForDenom query

* TotalDelegationByValidatorForDenom query

* TotalDelegationByValidatorForDenom query

* query

* save

* Update x/gamm/keeper/grpc_query.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update x/gamm/keeper/grpc_query.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update x/gamm/keeper/grpc_query.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* queries

* docs fix

* feat: add two pool shares queries to stargate whitelist

* chore: update changelog

* feat: generate proto files

* chore: generate proto files

* autocli copy from cosmos

* reset

* save

* SimJoinPoolNoSwap

* docs

* JoinPoolNoSwap simulation

* more fixes

* fix docs and name

* fix: change tokens_in type

* test: fix TestCalcJoinPoolNoSwapShares test

* feat: build query.pb.go file

* name version >>

* update action v

* check variable

* action from personal fork

* remove tag

* chore: remove whitespace

Co-authored-by: Roman <[email protected]>

* chore: workflow files

* chore: fix docker.yml file

* chore: fix required_labels.yml

* chore: remove space

* Update CHANGELOG.md

Co-authored-by: Matt, Park <[email protected]>

Co-authored-by: Ruslan Akhtariev <[email protected]>
Co-authored-by: Ruslan Akhtariev <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Matt, Park <[email protected]>
(cherry picked from commit 03ec730)

Co-authored-by: George <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v13.x backport patches to v13.x branch V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants